Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: check field data type of input (#32777) #32789

Merged
merged 1 commit into from
May 7, 2024

Conversation

longjiquan
Copy link
Contributor

issue: #32769
pr: #32777

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label May 6, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 6, 2024
@czs007
Copy link
Contributor

czs007 commented May 6, 2024

/approve
/lgtm

@sre-ci-robot sre-ci-robot added lgtm approved area/compilation area/test sig/testing size/XXL Denotes a PR that changes 1000+ lines. test/integration integration test and removed lgtm size/L Denotes a PR that changes 100-499 lines. labels May 6, 2024
@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels May 7, 2024
Copy link
Contributor

mergify bot commented May 7, 2024

@longjiquan Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/XXL Denotes a PR that changes 1000+ lines. labels May 7, 2024
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels May 7, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 81.77%. Comparing base (def4e14) to head (31e069f).
Report is 1 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #32789      +/-   ##
==========================================
- Coverage   81.79%   81.77%   -0.02%     
==========================================
  Files         998      998              
  Lines      124367   124401      +34     
==========================================
+ Hits       101720   101726       +6     
- Misses      18772    18801      +29     
+ Partials     3875     3874       -1     
Files Coverage Δ
internal/proxy/validate_util.go 90.43% <83.33%> (-0.98%) ⬇️

... and 37 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 7, 2024
@czs007
Copy link
Contributor

czs007 commented May 7, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 2a4a569 into milvus-io:2.4 May 7, 2024
15 checks passed
@longjiquan longjiquan deleted the fix-validate-util-24 branch May 7, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants