Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] Refine index param check for Create/Alter Index (#32712) #32784

Merged
merged 1 commit into from
May 6, 2024

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #32712
See also #32711

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/L Denotes a PR that changes 100-499 lines. labels May 6, 2024
@sre-ci-robot sre-ci-robot requested review from cydrain and sunby May 6, 2024 09:35
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 6, 2024
Copy link
Contributor

mergify bot commented May 6, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.74%. Comparing base (fe7a177) to head (b54ea1a).
Report is 1 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #32784      +/-   ##
==========================================
+ Coverage   81.45%   81.74%   +0.28%     
==========================================
  Files         998      998              
  Lines      124375   124367       -8     
==========================================
+ Hits       101306   101658     +352     
+ Misses      19190    18819     -371     
- Partials     3879     3890      +11     
Files Coverage Δ
internal/datacoord/index_service.go 94.91% <100.00%> (+1.07%) ⬆️
internal/datacoord/indexnode_manager.go 90.14% <100.00%> (-0.28%) ⬇️

... and 29 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 6, 2024
@czs007
Copy link
Contributor

czs007 commented May 6, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 0fc6b22 into milvus-io:2.4 May 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants