fix: Validate num of rows for insert field data with schema #32770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mergify
bot
added
dco-passed
|
@congqixia E2e jenkins job failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #32770 +/- ##
==========================================
- Coverage 81.77% 81.74% -0.03%
==========================================
Files 1001 1001
Lines 125359 125407 +48
==========================================
+ Hits 102508 102515 +7
- Misses 18966 19000 +34
- Partials 3885 3892 +7
|
See also milvus-io#32769 Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
congqixia
force-pushed
the
fix/validate_nrow_schema
branch
from
7c4adf4
to
c0f381d
Compare
sre-ci-robot
added
size/L
|
/lgtm |
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
May 7, 2024
…o#32770) See also milvus-io#32769 --------- Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
May 7, 2024
) (#32799) Cherry-pick from master pr: #32770 See also #32769 Signed-off-by: Congqi Xia <[email protected]>
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
May 8, 2024
…o#32770) See also milvus-io#32769 --------- Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
May 8, 2024
…2770) (#32845) Cherry-pick from master pr: #32770 See also #32769 Signed-off-by: Congqi Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #32769