Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove flaky sparse integration test #32767

Merged
merged 1 commit into from May 6, 2024

Conversation

zhengbuqian
Copy link
Collaborator

issue: #32766

this test is outdated, thus removing it instead of fixing it.

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. area/test sig/testing test/integration integration test labels May 6, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 6, 2024
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.77%. Comparing base (967cfb3) to head (e0d24b9).
Report is 35 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32767      +/-   ##
==========================================
+ Coverage   81.72%   81.77%   +0.04%     
==========================================
  Files         998      998              
  Lines      124044   124292     +248     
==========================================
+ Hits       101374   101635     +261     
+ Misses      18799    18796       -3     
+ Partials     3871     3861      -10     

see 55 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented May 6, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels May 6, 2024
@sre-ci-robot sre-ci-robot merged commit 37a99ca into milvus-io:master May 6, 2024
14 checks passed
@zhengbuqian zhengbuqian deleted the sparse-flaky-test branch May 6, 2024 11:20
czs007 pushed a commit that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled sig/testing size/S Denotes a PR that changes 10-29 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants