New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Add metautil.Channel
to convert string compare to int
#32749
enhance: Add metautil.Channel
to convert string compare to int
#32749
Conversation
@congqixia E2e jenkins job failed, comment |
1 similar comment
@congqixia E2e jenkins job failed, comment |
@congqixia ut workflow job failed, comment |
1 similar comment
@congqixia ut workflow job failed, comment |
@congqixia E2e jenkins job failed, comment |
1 similar comment
@congqixia E2e jenkins job failed, comment |
/run-cpu-e2e |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #32749 +/- ##
==========================================
- Coverage 81.77% 81.74% -0.04%
==========================================
Files 1001 1002 +1
Lines 125359 125437 +78
==========================================
+ Hits 102508 102534 +26
- Misses 18966 18996 +30
- Partials 3885 3907 +22
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bb489c4
to
f4c8710
Compare
@congqixia ut workflow job failed, comment |
See also milvus-io#32748 This PR: - Add `metautil.Channel` utiltiy which convert virtual name to physical channel name, collectionID and shard idx - Add channel mapper interface & implementation to convert limited physical channel name into int index - Apply `metautil.Channel` filter in querynode segment manager logic Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
f4c8710
to
836d138
Compare
@Mergifyio refresh |
✅ Pull request refreshed |
/lgtm |
See also #32748
This PR:
metautil.Channel
utiltiy which convert virtual name to physical channel name, collectionID and shard idxmetautil.Channel
filter in querynode segment manager logic