Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add metautil.Channel to convert string compare to int #32749

Merged
merged 5 commits into from May 7, 2024

Conversation

congqixia
Copy link
Contributor

See also #32748

This PR:

  • Add metautil.Channel utiltiy which convert virtual name to physical channel name, collectionID and shard idx
  • Add channel mapper interface & implementation to convert limited physical channel name into int index
  • Apply metautil.Channel filter in querynode segment manager logic

@sre-ci-robot sre-ci-robot added approved size/XL Denotes a PR that changes 500-999 lines. labels Apr 30, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Apr 30, 2024
Copy link
Contributor

mergify bot commented Apr 30, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
Copy link
Contributor

mergify bot commented Apr 30, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 30, 2024

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

1 similar comment
Copy link
Contributor

mergify bot commented Apr 30, 2024

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 30, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
Copy link
Contributor

mergify bot commented Apr 30, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 82.47423% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 81.74%. Comparing base (600db9d) to head (836d138).
Report is 21 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32749      +/-   ##
==========================================
- Coverage   81.77%   81.74%   -0.04%     
==========================================
  Files        1001     1002       +1     
  Lines      125359   125437      +78     
==========================================
+ Hits       102508   102534      +26     
- Misses      18966    18996      +30     
- Partials     3885     3907      +22     
Files Coverage Δ
internal/querynodev2/segments/segment_loader.go 71.84% <100.00%> (ø)
internal/querynodev2/services.go 90.61% <100.00%> (ø)
internal/querynodev2/segments/segment_l0.go 64.86% <50.00%> (-1.34%) ⬇️
internal/querynodev2/segments/manager.go 76.03% <50.00%> (-0.45%) ⬇️
internal/querynodev2/segments/segment.go 66.83% <75.00%> (-0.25%) ⬇️
pkg/util/metautil/channel.go 89.83% <89.83%> (ø)

... and 28 files with indirect coverage changes

@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented May 6, 2024

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

See also milvus-io#32748

This PR:

- Add `metautil.Channel` utiltiy which convert virtual name to physical
  channel name, collectionID and shard idx
- Add channel mapper interface & implementation to convert limited
  physical channel name into int index
- Apply `metautil.Channel` filter in querynode segment manager logic

Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
@congqixia
Copy link
Contributor Author

@Mergifyio refresh

Copy link
Contributor

mergify bot commented May 7, 2024

refresh

✅ Pull request refreshed

@yanliang567 yanliang567 added the manual-pass manually set pass before ci-passed labeled label May 7, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 40728ce into milvus-io:master May 7, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants