Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove empty assert of insert_record. #32747

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Remove empty assert of insert_record. #32747

wants to merge 1 commit into from
+5 −3

Conversation

v1incent
Copy link

@v1incent v1incent commented Apr 30, 2024 •
edited

issue: #32744
For pk field, it was not allowed to firstly load the index and then load the field data.
This RP removed the limitation.

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Apr 30, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: v1incent
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Apr 30, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 30, 2024

@v1incent Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added kind/bug Issues or changes related a bug do-not-merge/missing-related-issue labels Apr 30, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 30, 2024

@v1incent Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Apr 30, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 30, 2024

@v1incent E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@v1incent v1incent changed the title fix: Remove empty assert of insert_record. #32744 fix: Remove empty assert of insert_record. Apr 30, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 30, 2024

@v1incent E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Contributor

czs007 commented May 7, 2024

/run-cpu-e2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees
No one assigned
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@v1incent @sre-ci-robot @czs007