Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add Wrapper and Keepalive for CTraceContext ids #32746

Merged

Conversation

congqixia
Copy link
Contributor

See also #32742

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@congqixia congqixia changed the title fix: Add Wrapper and Keepalive for CCTraceContext ids fix: Add Wrapper and Keepalive for CTraceContext ids Apr 30, 2024
@sre-ci-robot sre-ci-robot added approved size/M Denotes a PR that changes 30-99 lines. labels Apr 30, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Apr 30, 2024
Copy link
Contributor

mergify bot commented Apr 30, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Apr 30, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 30, 2024

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 30, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.72%. Comparing base (600db9d) to head (ea62399).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32746      +/-   ##
==========================================
- Coverage   81.77%   81.72%   -0.05%     
==========================================
  Files        1001     1001              
  Lines      125359   125365       +6     
==========================================
- Hits       102508   102454      -54     
- Misses      18966    19021      +55     
- Partials     3885     3890       +5     
Files Coverage Δ
internal/querynodev2/segments/load_index_info.go 73.33% <100.00%> (+0.19%) ⬆️
internal/querynodev2/segments/trace.go 100.00% <100.00%> (ø)
internal/querynodev2/segments/segment.go 67.08% <66.66%> (-0.01%) ⬇️

... and 34 files with indirect coverage changes

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@longjiquan
Copy link
Contributor

/lgtm

Copy link
Contributor

mergify bot commented May 6, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 6, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia congqixia force-pushed the fix/add_wrap_keepalive_cctx branch from 7367a9c to 22bd21c Compare May 6, 2024 09:20
@sre-ci-robot sre-ci-robot removed the lgtm label May 6, 2024
@mergify mergify bot added the ci-passed label May 6, 2024
@congqixia congqixia force-pushed the fix/add_wrap_keepalive_cctx branch from 22bd21c to ea62399 Compare May 6, 2024 14:12
@mergify mergify bot added ci-passed and removed ci-passed labels May 6, 2024
@longjiquan
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 7102403 into milvus-io:master May 7, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants