Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make the dynamic column optional in parquet import #32738

Merged
merged 1 commit into from May 7, 2024
Merged

fix: Make the dynamic column optional in parquet import #32738

merged 1 commit into from May 7, 2024

Conversation

bigsheeper
Copy link
Contributor

issue: #32729

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/test sig/testing test/integration integration test labels Apr 30, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Apr 30, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 30, 2024 •
edited

Codecov Report

Attention: Patch coverage is 83.87097% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 81.78%. Comparing base (77f4f0c) to head (38d81f7).
Report is 23 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32738      +/-   ##
==========================================
+ Coverage   81.72%   81.78%   +0.05%     
==========================================
  Files         998      999       +1     
  Lines      125433   124297    -1136     
==========================================
- Hits       102510   101653     -857     
+ Misses      19075    18777     -298     
- Partials     3848     3867      +19
Files Coverage Δ
internal/util/importutilv2/numpy/reader.go 73.07% <100.00%> (ø)
internal/util/importutilv2/numpy/util.go 42.65% <ø> (-6.75%) ⬇️
internal/util/importutilv2/parquet/util.go 74.44% <100.00%> (+0.84%) ⬆️
internal/util/importutilv2/parquet/reader.go 65.71% <33.33%> (-1.45%) ⬇️
internal/util/importutilv2/common/util.go 88.00% <88.00%> (ø)

... and 138 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Apr 30, 2024
@czs007
Copy link
Contributor

czs007 commented May 7, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 4de063a into milvus-io:master May 7, 2024
15 checks passed
bigsheeper added a commit to bigsheeper/milvus that referenced this pull request May 7, 2024
@bigsheeper
fix: Make the dynamic column optional in parquet import (milvus-io#32738
1d55334 
)

issue: milvus-io#32729

Signed-off-by: bigsheeper <[email protected]>
@bigsheeper bigsheeper mentioned this pull request May 7, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request May 7, 2024
@bigsheeper
fix: Make the dynamic column optional in parquet import (#32738) (#32802
54e00db 
)

issue: #32729

pr: #32738

Signed-off-by: bigsheeper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@wayblink wayblink Awaiting requested review from wayblink

Assignees

@czs007 czs007

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bigsheeper @czs007 @sre-ci-robot