Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add more trace for search & query #32734

Merged
merged 6 commits into from May 7, 2024

Conversation

longjiquan
Copy link
Contributor

issue: #32728

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Apr 30, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Apr 30, 2024
Copy link
Contributor

mergify bot commented Apr 30, 2024

@longjiquan ut workflow job failed, comment rerun ut can trigger the job again.

1 similar comment
Copy link
Contributor

mergify bot commented Apr 30, 2024

@longjiquan ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented May 6, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented May 6, 2024

@longjiquan ut workflow job failed, comment rerun ut can trigger the job again.

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 90.19608% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 81.72%. Comparing base (83ce352) to head (99adcea).
Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32734      +/-   ##
==========================================
- Coverage   81.77%   81.72%   -0.06%     
==========================================
  Files        1001     1001              
  Lines      125359   125450      +91     
==========================================
+ Hits       102517   102519       +2     
- Misses      18956    19018      +62     
- Partials     3886     3913      +27     
Files Coverage Δ
internal/core/src/segcore/Reduce.cpp 93.18% <100.00%> (+0.13%) ⬆️
internal/core/src/segcore/Reduce.h 100.00% <100.00%> (ø)
internal/core/src/segcore/SegmentInterface.h 100.00% <ø> (ø)
internal/core/src/segcore/reduce_c.cpp 68.65% <100.00%> (+1.99%) ⬆️
internal/proxy/task_search.go 77.46% <100.00%> (+0.22%) ⬆️
internal/querynodev2/segments/reduce.go 75.90% <100.00%> (+0.29%) ⬆️
internal/querynodev2/segments/result.go 74.75% <100.00%> (+0.74%) ⬆️
internal/core/src/segcore/segment_c.cpp 57.79% <50.00%> (-0.23%) ⬇️
internal/core/src/segcore/SegmentInterface.cpp 88.50% <62.50%> (-0.39%) ⬇️

... and 27 files with indirect coverage changes

Signed-off-by: longjiquan <[email protected]>
Signed-off-by: longjiquan <[email protected]>
Signed-off-by: longjiquan <[email protected]>
Copy link
Contributor

mergify bot commented May 6, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
Copy link
Contributor

mergify bot commented May 6, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@longjiquan
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label May 6, 2024
Signed-off-by: longjiquan <[email protected]>
@mergify mergify bot removed the ci-passed label May 7, 2024
Copy link
Contributor

mergify bot commented May 7, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Contributor

czs007 commented May 7, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label May 7, 2024
@sre-ci-robot sre-ci-robot merged commit 1f58cda into milvus-io:master May 7, 2024
15 checks passed
@longjiquan longjiquan deleted the enhance-profiling branch May 7, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants