Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: expose DescribeDatabase api in proxy #32732

Merged
merged 2 commits into from May 9, 2024
Merged

enhance: expose DescribeDatabase api in proxy #32732

merged 2 commits into from May 9, 2024

Conversation

weiliu1031
Copy link
Contributor

issue: #32707

@sre-ci-robot sre-ci-robot added area/dependency Pull requests that update a dependency file size/L Denotes a PR that changes 100-499 lines. labels Apr 30, 2024
@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Apr 30, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 30, 2024

@weiliu1031 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 30, 2024

@weiliu1031

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly

Please review and update your PR to comply with these guidelines.

@weiliu1031 weiliu1031 changed the title enahance: expose DescribeDatabase api in proxy enhance: expose DescribeDatabase api in proxy Apr 30, 2024
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Apr 30, 2024
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Apr 30, 2024
@codecov Codecov
Copy link

codecov bot commented May 7, 2024 •
edited

Codecov Report

Attention: Patch coverage is 88.54962% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 81.79%. Comparing base (17a79f4) to head (f0f8c69).
Report is 13 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #32732   +/-   ##
=======================================
  Coverage   81.78%   81.79%           
=======================================
  Files        1006     1006           
  Lines      126749   126845   +96     
=======================================
+ Hits       103664   103754   +90     
+ Misses      19147    19144    -3     
- Partials     3938     3947    +9
Files Coverage Δ
internal/distributed/proxy/service.go 84.06% <100.00%> (+0.04%) ⬆️
internal/proxy/task.go 88.11% <ø> (-0.17%) ⬇️
internal/rootcoord/describe_db_task.go 86.66% <100.00%> (+0.95%) ⬆️
internal/proxy/impl.go 86.43% <88.09%> (+0.01%) ⬆️
internal/proxy/task_database.go 94.47% <88.37%> (-5.53%) ⬇️

... and 25 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 7, 2024
congqixia
congqixia reviewed May 7, 2024
View reviewed changes
internal/proxy/task_database.go Outdated
Comment on lines 351 to 376
if err != nil {
return err
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe see merr.CheckRPCCall here?

@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels May 7, 2024
@mergify mergify bot removed the ci-passed label May 7, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 7, 2024

@weiliu1031 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented May 7, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label May 7, 2024
@congqixia
Copy link
Contributor

/cc @czs007

@sre-ci-robot sre-ci-robot requested a review from czs007 May 8, 2024 11:18
@mergify mergify bot removed the ci-passed label May 8, 2024
@czs007
Copy link
Contributor

czs007 commented May 8, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify Mergify
Copy link
Contributor

mergify bot commented May 8, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented May 9, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label May 9, 2024
@sre-ci-robot sre-ci-robot merged commit c35797c into milvus-io:master May 9, 2024
15 checks passed
UnyieldingOrca pushed a commit to UnyieldingOrca/milvus that referenced this pull request May 10, 2024
@weiliu1031
enhance: expose DescribeDatabase api in proxy (milvus-io#32732)
37c09b1 
issue: milvus-io#32707

---------

Signed-off-by: Wei Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia left review comments

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@cydrain cydrain Awaiting requested review from cydrain

@czs007 czs007 Awaiting requested review from czs007

Assignees

@czs007 czs007

Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@weiliu1031 @congqixia @czs007 @sre-ci-robot