Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix cannot specify partition name in binlog import #32730

Merged
merged 6 commits into from May 7, 2024
Merged

fix: Fix cannot specify partition name in binlog import #32730

merged 6 commits into from May 7, 2024

Conversation

bigsheeper
Copy link
Contributor

@bigsheeper bigsheeper commented Apr 30, 2024 •
edited

issue: #32807

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Apr 30, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug do-not-merge/missing-related-issue labels Apr 30, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 30, 2024

@bigsheeper Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 30, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
fix case
381a4a6 
Signed-off-by: bigsheeper <[email protected]>
@czs007
Copy link
Contributor

czs007 commented May 6, 2024

@bigsheeper rebase from master
/approve

@sre-ci-robot sre-ci-robot added the test/integration integration test label May 7, 2024
@codecov Codecov
Copy link

codecov bot commented May 7, 2024 •
edited

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 81.80%. Comparing base (83ce352) to head (697b3ba).
Report is 18 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32730      +/-   ##
==========================================
+ Coverage   81.77%   81.80%   +0.02%     
==========================================
  Files        1001      992       -9     
  Lines      125359   125645     +286     
==========================================
+ Hits       102517   102788     +271     
- Misses      18956    18962       +6     
- Partials     3886     3895       +9
Files Coverage Δ
internal/proxy/impl.go 86.37% <81.81%> (-0.11%) ⬇️

... and 210 files with indirect coverage changes

@mergify mergify bot added ci-passed and removed ci-passed labels May 7, 2024
@bigsheeper
Copy link
Contributor Author

issue: #32807

@mergify Mergify
Copy link
Contributor

mergify bot commented May 7, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label May 7, 2024
@czs007
Copy link
Contributor

czs007 commented May 7, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 53874ce into milvus-io:master May 7, 2024
15 checks passed
bigsheeper added a commit to bigsheeper/milvus that referenced this pull request May 7, 2024
@bigsheeper
fix: Fix cannot specify partition name in binlog import (milvus-io#32730
b31626a 
)

issue: milvus-io#32807

---------

Signed-off-by: bigsheeper <[email protected]>
@bigsheeper bigsheeper mentioned this pull request May 7, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request May 8, 2024
@bigsheeper
fix: Fix cannot specify partition name in binlog import (#32730) (#32829
94bd2f0 
)

issue: #32807

pr: #32730

Signed-off-by: bigsheeper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees

@czs007 czs007

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm sig/testing size/M Denotes a PR that changes 30-99 lines. test/integration integration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bigsheeper @czs007 @sre-ci-robot