Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Upgrade bitset for ARM SVE #32718

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexanderguzhva
Copy link
Contributor

@alexanderguzhva alexanderguzhva commented Apr 29, 2024

issue: #32826
improve ARM SVE performance for internal/core/src/bitset

Baseline timings for gcc 11.4 + Graviton 3 + manually enabled SVE:
https://gist.github.com/alexanderguzhva/a974b50134c8bb9255fb15f144e5ac83

Candidate timings for gcc 11.4 + Graviton 3 + manually enabled SVE:
https://gist.github.com/alexanderguzhva/19fc88f4ad3757e05e0f7feaf563b3d3

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Apr 29, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alexanderguzhva
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Apr 29, 2024

@alexanderguzhva

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@alexanderguzhva alexanderguzhva changed the title Upgrade bitset for ARM SVE enhance: Upgrade bitset for ARM SVE Apr 29, 2024
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement do-not-merge/missing-related-issue and removed do-not-merge/invalid-pr-format labels Apr 29, 2024
Copy link
Contributor

mergify bot commented Apr 29, 2024

@alexanderguzhva Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.14%. Comparing base (efdbd8e) to head (d1f0bd4).
Report is 20 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32718      +/-   ##
==========================================
+ Coverage   82.12%   82.14%   +0.02%     
==========================================
  Files        1007      998       -9     
  Lines      127726   127941     +215     
==========================================
+ Hits       104894   105102     +208     
  Misses      18875    18875              
- Partials     3957     3964       +7     

see 215 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Apr 29, 2024
@zhagnlu
Copy link
Contributor

zhagnlu commented May 6, 2024

/lgtm

Copy link
Contributor

mergify bot commented May 7, 2024

@alexanderguzhva E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@alexanderguzhva
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 8, 2024

@alexanderguzhva E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@alexanderguzhva
Copy link
Contributor Author

/run-cpu-e2e

2 similar comments
@alexanderguzhva
Copy link
Contributor Author

/run-cpu-e2e

@alexanderguzhva
Copy link
Contributor Author

/run-cpu-e2e

Signed-off-by: Alexandr Guzhva <[email protected]>
@sre-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@alexanderguzhva
Copy link
Contributor Author

rebased to master

Copy link
Contributor

mergify bot commented May 13, 2024

@alexanderguzhva E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@alexanderguzhva
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 13, 2024

@alexanderguzhva E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@alexanderguzhva
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants