Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add request resource timeout for lazy load, refactor context usage in cache #32709

Merged
merged 1 commit into from May 7, 2024

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Apr 29, 2024

issue: #32663

  • Use new param to control request resource timeout for lazy load.

  • Remove the timeout parameter of Do, remove DoWait. use context to control the timeout.

  • Use VersionedNotifier to avoid notify event lost and broadcast, remove the redundant goroutine in cache.

related dev pr: #32684

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Apr 29, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Apr 29, 2024
Copy link
Contributor

mergify bot commented Apr 29, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
Copy link
Contributor

mergify bot commented Apr 29, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 29, 2024

@chyezh ut workflow job failed, comment rerun ut can trigger the job again.

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/XXL Denotes a PR that changes 1000+ lines. labels May 6, 2024
Copy link
Contributor

mergify bot commented May 6, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented May 6, 2024

@chyezh ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented May 7, 2024

@chyezh ut workflow job failed, comment rerun ut can trigger the job again.

…ge in cache (milvus-io#32684)

- Use new param to control request resource timeout for lazy load.

- Remove the timeout parameter of `Do`, remove `DoWait`. use `context` to control the timeout.

- Use `VersionedNotifier` to avoid notify event lost and broadcast, remove the redundant goroutine in cache.

---------

Signed-off-by: chyezh <[email protected]>
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 46.31579% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 81.71%. Comparing base (37a99ca) to head (7c285e4).
Report is 21 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32709      +/-   ##
==========================================
- Coverage   81.76%   81.71%   -0.05%     
==========================================
  Files         998     1002       +4     
  Lines      124284   125438    +1154     
==========================================
+ Hits       101621   102502     +881     
- Misses      18795    19027     +232     
- Partials     3868     3909      +41     
Files Coverage Δ
internal/querynodev2/segments/manager.go 76.48% <100.00%> (-2.52%) ⬇️
pkg/util/cache/cache.go 87.87% <100.00%> (-6.46%) ⬇️
pkg/util/paramtable/component_param.go 98.45% <100.00%> (+0.02%) ⬆️
internal/querynodev2/segments/utils.go 29.35% <0.00%> (+3.35%) ⬆️
pkg/util/contextutil/context_util.go 75.51% <69.23%> (-2.27%) ⬇️
internal/querynodev2/segments/retrieve.go 78.99% <0.00%> (-5.89%) ⬇️
internal/querynodev2/segments/search.go 68.11% <0.00%> (-21.74%) ⬇️
pkg/util/paramtable/param_item.go 83.75% <33.33%> (-6.02%) ⬇️
internal/querynodev2/segments/segment_loader.go 71.25% <0.00%> (-0.84%) ⬇️

... and 45 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented May 7, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 641f702 into milvus-io:master May 7, 2024
14 of 15 checks passed
@chyezh chyezh deleted the fix_lru_master branch May 7, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants