Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: update knowhere version #32696

Closed
wants to merge 78 commits into from
Closed

enhance: update knowhere version #32696

wants to merge 78 commits into from

Conversation

chasingegg
Copy link
Contributor

No description provided.

chyezh and others added 30 commits April 3, 2024 12:07
@chyezh
Fix partital release (milvus-io#31866)
409ed92 
Signed-off-by: chyezh <[email protected]>
@chyezh
Add metric for lru and fix lost delete data when enable lazy load (mi…
29367aa 
…lvus-io#31868)

Signed-off-by: chyezh <[email protected]>
@MrPresent-Han
feat: Support stream reduce v1 (milvus-io#31873)
6122402 
related: milvus-io#31410

---------

Signed-off-by: MrPresent-Han <[email protected]>
@sunby
Change do wait lru dev (milvus-io#31878)
746e1cb 
Signed-off-by: sunby <[email protected]>
@chyezh
enhance: add config for disk cache (milvus-io#31881)
96bcc06
@sunby
fix config not initialized (milvus-io#31890)
ed77f26 
Signed-off-by: sunby <[email protected]>
@sunby
fix error handle in search (milvus-io#31895)
211a386 
Signed-off-by: sunby <[email protected]>
@chyezh
fix: thread safe vector (milvus-io#31898)
6245b19
@chyezh
fix: insert record cannot reinsert (milvus-io#31900)
6eb334a
@MrPresent-Han
enhance: cancel concurrency restrict for stream reduce and add metrics (
55680b6 
milvus-io#31892)

Signed-off-by: MrPresent-Han <[email protected]>
@chyezh
fix: bit set (milvus-io#31905)
5153436
@MrPresent-Han
fix bitset clear to reset (milvus-io#31908)
9040b0f 
Signed-off-by: MrPresent-Han <[email protected]>
@MrPresent-Han
Fix 0404 lru dev (milvus-io#31914)
d4659f1 
fix:
1. sealed_segment num_rows reset to std::null opt
2. sealed_segment lazy_load reset to true after evicting to avoid
shortcut

---------

Signed-off-by: MrPresent-Han <[email protected]>
@MrPresent-Han
fix possible block due to unpin fifo activating principle (milvus-io#…
3ec8fe2 
…31924)

Signed-off-by: MrPresent-Han <[email protected]>
@sunby
Add lru reloader lru dev (milvus-io#31952)
21a955c 
Signed-off-by: sunby <[email protected]>
@sunby
fix query limit (milvus-io#32060)
80e415a 
Signed-off-by: sunby <[email protected]>
@chyezh
fix: lru cache lost delete and wrong mem size (milvus-io#32072)
fb0b93d 
issue: milvus-io#30361

Signed-off-by: chyezh <[email protected]>
@chyezh
enhance: add more metrics for cache and search (milvus-io#31777) (mil…
84da1bf 
…vus-io#32097)

issue: milvus-io#30931

Signed-off-by: chyezh <[email protected]>
@MrPresent-Han
fix:panic due to empty search result when stream reducing(milvus-io#3…
d1e5f6b 
…2009) (milvus-io#32083)

related: milvus-io#32009

Signed-off-by: MrPresent-Han <[email protected]>
@chyezh
fix: sealed segment may not exist when throw (milvus-io#32098)
adfed78 
issue: milvus-io#30361

Signed-off-by: chyezh <[email protected]>
@wayblink @chasingegg
Major compaction 1st edition (milvus-io#31804) (milvus-io#32116)
6e67e5a 
Signed-off-by: wayblink <[email protected]>
Signed-off-by: Cai Zhang <[email protected]>
Signed-off-by: chasingegg <[email protected]>
Co-authored-by: chasingegg <[email protected]>
@chyezh
fix: inconsistent between state lock and load state (milvus-io#32171)
ab4a583 
issue: milvus-io#30361

Signed-off-by: chyezh <[email protected]>
@xiaocai2333 @jaime0815
enhance: Throw error instead of crash when index cannot be built (mil…
9126638 
…vus-io#31844)

issue: milvus-io#27589

---------

Signed-off-by: Cai Zhang <[email protected]>

(cherry picked from commit 1b76766)
Signed-off-by: jaime <[email protected]>
@chasingegg
update knowhere to support clustering (milvus-io#32188)
159bcf5 
Signed-off-by: chasingegg <[email protected]>
@chyezh
fix: segment release is not sync with cache (milvus-io#32212)
1023c2b 
issue: milvus-io#32206

Signed-off-by: chyezh <[email protected]>
@MrPresent-Han
fix: incorrect pinCount resulting unexpected eviction(milvus-io#32136) (
9e7ed00 
milvus-io#32238)

related: milvus-io#32136

Signed-off-by: MrPresent-Han <[email protected]>
@MrPresent-Han
fix: possible panic when stream reducing (milvus-io#32247)
278b716 
related: milvus-io#32009

Signed-off-by: MrPresent-Han <[email protected]>
@SimFG
enhance: [lru-dev] add the related data size for the read apis (milvu…
be3d4c1 
…s-io#32274)

cherry-pick: milvus-io#31816

---------

Signed-off-by: SimFG <[email protected]>
@xiaocai2333
add debug log (milvus-io#32303)
fc20600 
Signed-off-by: Cai Zhang <[email protected]>
@xiaocai2333
Refine code for analyze task scheduler (milvus-io#32122)
cf7d7c7 
Signed-off-by: Cai Zhang <[email protected]>
@yanliang567 yanliang567 removed this from the 2.4.1 milestone Apr 29, 2024
@chasingegg
Copy link
Contributor Author

chasingegg commented Apr 29, 2024 •
edited

wait until 2.4.1 release

@chasingegg
Copy link
Contributor Author

/hold

chyezh and others added 6 commits April 29, 2024 16:05
@chyezh
fix: add request resource timeout for lazy load, refactor context usa…
d72821c 
…ge in cache (milvus-io#32684)

issue: milvus-io#32663

- use new param to control request resource timeout for lazy load。
- remove the timeout parameter of `Do`, remove `DoWait`. use `context`
to control the timeout.
- use `VersionedNotifier` to avoid notify event lost and broadcast,
remove the redundant goroutine in cache.

---------

Signed-off-by: chyezh <[email protected]>
@xiaocai2333
Use a ratio instead of a fixed value for train size (milvus-io#32708)
9234a94 
Signed-off-by: Cai Zhang <[email protected]>
@chasingegg
fix mmap (milvus-io#32785)
2721816 
Signed-off-by: chasingegg <[email protected]>
@xiaocai2333
Refine datanode major compaction (milvus-io#32471)
aa827c6 
Signed-off-by: Cai Zhang <[email protected]>
@MrPresent-Han
enhance: change prune ratio meaning(milvus-io#32866) (milvus-io#32867)
b194d07 
related: milvus-io#32866

Signed-off-by: MrPresent-Han <[email protected]>
@chasingegg
enhance: update knowhere and remove unused function
6baffd1 
Signed-off-by: chasingegg <[email protected]>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chasingegg
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added area/internal-api area/test sig/testing test/integration integration test size/XXL Denotes a PR that changes 1000+ lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels May 9, 2024
@chasingegg chasingegg closed this May 9, 2024
@chasingegg chasingegg deleted the update-knowhere branch May 9, 2024 11:17
@mergify mergify bot added the needs-dco DCO is missing in this pull request. label May 9, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 9, 2024

@chasingegg Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot removed the dco-passed DCO check passed. label May 9, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 9, 2024

@chasingegg Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@chasingegg chasingegg restored the update-knowhere branch May 9, 2024 11:17
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels May 9, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 9, 2024

⚠️ The sha of the head commit of this PR conflicts with #32906. Mergify cannot evaluate rules on this PR. ⚠️

@chasingegg chasingegg deleted the update-knowhere branch May 9, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees
No one assigned
Labels
area/compilation area/internal-api area/test dco-passed DCO check passed. do-not-merge/hold do-not-merge/missing-related-issue kind/enhancement Issues or changes related to enhancement sig/testing size/XXL Denotes a PR that changes 1000+ lines. test/integration integration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet