Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add channelCPs in FlushResponse #32683

Merged
merged 1 commit into from May 10, 2024
Merged

Conversation

wayblink
Copy link
Contributor

@wayblink wayblink commented Apr 28, 2024

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Apr 28, 2024
Copy link
Contributor

mergify bot commented Apr 28, 2024

@wayblink Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

Copy link
Contributor

mergify bot commented Apr 28, 2024

@wayblink

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@wayblink wayblink changed the title Add channelCPs in FlushResponse enhance: Add channelCPs in FlushResponse Apr 28, 2024
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Apr 28, 2024
Copy link
Contributor

mergify bot commented Apr 28, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 28, 2024

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 29, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Contributor

czs007 commented Apr 29, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Apr 29, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 29, 2024

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

@sre-ci-robot sre-ci-robot added the area/dependency Pull requests that update a dependency file label Apr 29, 2024
Copy link
Contributor

mergify bot commented Apr 29, 2024

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented May 8, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@wayblink
Copy link
Contributor Author

wayblink commented May 8, 2024

rerun ut

2 similar comments
@wayblink
Copy link
Contributor Author

wayblink commented May 8, 2024

rerun ut

@czs007
Copy link
Contributor

czs007 commented May 9, 2024

rerun ut

@wayblink wayblink force-pushed the cdc-2.3 branch 2 times, most recently from 34af9dc to 40090da Compare May 9, 2024 13:29
Copy link
Contributor

mergify bot commented May 9, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.12%. Comparing base (2facf61) to head (e126b27).
Report is 3 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #32683      +/-   ##
==========================================
+ Coverage   83.10%   83.12%   +0.01%     
==========================================
  Files         850      850              
  Lines      106557   106614      +57     
==========================================
+ Hits        88555    88623      +68     
+ Misses      14704    14694      -10     
+ Partials     3298     3297       -1     
Files Coverage Δ
internal/datacoord/meta.go 89.74% <100.00%> (-0.21%) ⬇️
internal/datacoord/server.go 71.86% <100.00%> (-0.42%) ⬇️
internal/datacoord/services.go 86.31% <100.00%> (+0.18%) ⬆️
internal/proxy/task.go 87.44% <100.00%> (+0.03%) ⬆️
internal/rootcoord/broker.go 90.75% <100.00%> (+0.05%) ⬆️

... and 19 files with indirect coverage changes

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels May 9, 2024
@mergify mergify bot added the ci-passed label May 9, 2024
@czs007
Copy link
Contributor

czs007 commented May 10, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, wayblink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 996b79c into milvus-io:2.3 May 10, 2024
14 checks passed
@czs007
Copy link
Contributor

czs007 commented May 10, 2024

pr: #32044

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants