Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: refactor segcore plan executor module #32637

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Apr 26, 2024

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhagnlu
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. area/compilation labels Apr 26, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Apr 26, 2024
Copy link
Contributor

mergify bot commented Apr 26, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Apr 26, 2024

@zhagnlu ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented May 6, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu
Copy link
Contributor Author

zhagnlu commented May 9, 2024

rerun ut

Copy link
Contributor

mergify bot commented May 9, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu
Copy link
Contributor Author

zhagnlu commented May 10, 2024

rerun ut

Copy link
Contributor

mergify bot commented May 11, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu
Copy link
Contributor Author

zhagnlu commented May 11, 2024

rerun ut

Copy link
Contributor

mergify bot commented May 13, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu
Copy link
Contributor Author

zhagnlu commented May 13, 2024

/run-cpu-e2e

@zhagnlu
Copy link
Contributor Author

zhagnlu commented May 13, 2024

rerun ut

1 similar comment
@zhagnlu
Copy link
Contributor Author

zhagnlu commented May 13, 2024

rerun ut

Copy link
Contributor

mergify bot commented May 13, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 70.98540% with 159 lines in your changes are missing coverage. Please review.

Project coverage is 83.53%. Comparing base (589d4df) to head (376ea42).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32637      +/-   ##
==========================================
+ Coverage   82.19%   83.53%   +1.34%     
==========================================
  Files        1005      998       -7     
  Lines      129863   127576    -2287     
==========================================
- Hits       106736   106569     -167     
+ Misses      19148    17024    -2124     
- Partials     3979     3983       +4     
Files Coverage Δ
internal/core/src/bitset/bitset.h 98.63% <ø> (+5.93%) ⬆️
internal/core/src/common/Types.h 31.45% <ø> (ø)
internal/core/src/common/Utils.h 90.00% <100.00%> (+0.28%) ⬆️
internal/core/src/common/Vector.h 100.00% <100.00%> (ø)
internal/core/src/exec/QueryContext.h 85.29% <100.00%> (+7.03%) ⬆️
internal/core/src/exec/operator/CountNode.cpp 100.00% <100.00%> (ø)
internal/core/src/exec/operator/FilterBits.cpp 96.61% <100.00%> (+2.86%) ⬆️
...nternal/core/src/exec/operator/GroupByOperator.cpp 96.42% <ø> (ø)
internal/core/src/exec/operator/GroupByOperator.h 79.24% <ø> (ø)
internal/core/src/expr/ITypeExpr.h 51.12% <ø> (ø)
... and 33 more

... and 40 files with indirect coverage changes

@zhagnlu
Copy link
Contributor Author

zhagnlu commented May 14, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 14, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented May 15, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu
Copy link
Contributor Author

zhagnlu commented May 15, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 15, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented May 15, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu
Copy link
Contributor Author

zhagnlu commented May 16, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 16, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu
Copy link
Contributor Author

zhagnlu commented May 21, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 24, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu
Copy link
Contributor Author

zhagnlu commented May 27, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 30, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compilation dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants