Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: [skip e2e] fetch value of GPU_DATE_VERSION from .env #32004

Merged
merged 1 commit into from
Apr 8, 2024
Merged

enhance: [skip e2e] fetch value of GPU_DATE_VERSION from .env #32004

merged 1 commit into from
Apr 8, 2024

Conversation

samhuang-z
Copy link
Collaborator

No description provided.

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Apr 8, 2024
@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Apr 8, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 8, 2024

@samhuang-z Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added the kind/enhancement Issues or changes related to enhancement label Apr 8, 2024
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Apr 8, 2024
@samhuang-z samhuang-z mentioned this pull request Apr 8, 2024
Merged
@samhuang-z samhuang-z changed the title enhance: identify milvusdb/milvus-env from .env enhance: [skip e2e] identify milvusdb/milvus-env from .env Apr 8, 2024
@mergify mergify bot added the ci-passed label Apr 8, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 8, 2024

@samhuang-z E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@samhuang-z samhuang-z changed the title enhance: [skip e2e] identify milvusdb/milvus-env from .env enhance: [skip e2e] fetch value of GPU_DATE_VERSION from .env Apr 8, 2024
LoveEachDay
LoveEachDay approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@LoveEachDay LoveEachDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 8, 2024

@samhuang-z E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yanliang567
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LoveEachDay, samhuang-z, yanliang567

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit a22dffd into milvus-io:master Apr 8, 2024
4 of 5 checks passed
sre-ci-robot pushed a commit that referenced this pull request Apr 8, 2024
@samhuang-z
enhance: [skip e2e] fetch value of GPU_DATE_VERSION from .env (#32005)
233032d 
pr: #32004

Signed-off-by: Liang Huang <[email protected]>
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 8, 2024

@samhuang-z E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoveEachDay LoveEachDay LoveEachDay approved these changes

@czs007 czs007 Awaiting requested review from czs007

@sunby sunby Awaiting requested review from sunby

Assignees

@LoveEachDay LoveEachDay

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@samhuang-z @yanliang567 @sre-ci-robot @LoveEachDay