Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: [2.3] Add param item to ignore bad message id in checkpoint #33128

Merged
merged 2 commits into from
May 20, 2024
Merged

enhance: [2.3] Add param item to ignore bad message id in checkpoint #33128

merged 2 commits into from
May 20, 2024

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #33123
See also #33122

This pr add param item mq.ignoreBadPosition to control behavior when mq failed to parse message id from checkpoint

@congqixia
enhance: Add param item to ignore bad message id in checkpoint
05ce8c5 
See also milvus-io#33122

This pr add param item `mq.ignoreBadPosition` to control behavior when
mq failed to parse message id from checkpoint

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. approved labels May 17, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 17, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 17, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented May 17, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented May 17, 2024 •
edited

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 83.09%. Comparing base (bbf3a27) to head (738b3f4).
Report is 2 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #33128      +/-   ##
==========================================
+ Coverage   83.06%   83.09%   +0.02%     
==========================================
  Files         850      850              
  Lines      106629   106641      +12     
==========================================
+ Hits        88576    88613      +37     
+ Misses      14742    14730      -12     
+ Partials     3311     3298      -13
Files Coverage Δ
pkg/util/paramtable/service_param.go 98.35% <100.00%> (+0.01%) ⬆️
pkg/mq/msgstream/mq_msgstream.go 82.19% <71.42%> (+1.24%) ⬆️

... and 17 files with indirect coverage changes

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels May 17, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 17, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented May 17, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@congqixia congqixia added this to the 2.3.16 milestone May 17, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 17, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented May 17, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented May 17, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label May 20, 2024
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit f848e82 into milvus-io:2.3 May 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@xiaofan-luan xiaofan-luan

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
2.3.16
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@congqixia @xiaofan-luan @sre-ci-robot