Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: TestSparse_invalid_insert is flaky #32766

Closed
1 task done
zhengbuqian opened this issue May 6, 2024 · 0 comments
Closed
1 task done

[Bug]: TestSparse_invalid_insert is flaky #32766

zhengbuqian opened this issue May 6, 2024 · 0 comments
Assignees
Labels
kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@zhengbuqian
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: master

Current Behavior

TestSparse_invalid_insert is flaky.

The test was originally designed to test against negative sparse vector index, but we later changed to use uint32 instead of int32 as the index type, thus it became impossible to have a negative index: negative int32 is a super large uint32, which is legal.

This test tried to catch illegal negative index by setting the first index of the first row to -10 and verify the insertion to fail. The reason the test is flaky:

  1. when we generate more than 1 non zero element in the first row, all indexes are between 0 and 700(as in testutils.GenerateSparseFloatVectors), if we set the first index to -10, after being interpreted as uint32, it is a very large value, violating the indexes in the same row must be sorted rule, causing the insertion to fail and the test to pass.
  2. when we generated only 1 non zero element in the first row and we set the first index to -10, this row is a legal row with a super large index, thus the insertion will succeed and the test fails.

Expected Behavior

No response

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response

@zhengbuqian zhengbuqian added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 6, 2024
@zhengbuqian zhengbuqian self-assigned this May 6, 2024
sre-ci-robot pushed a commit that referenced this issue May 6, 2024
issue: #32766

this test is outdated, thus removing it instead of fixing it.

Signed-off-by: Buqian Zheng <[email protected]>
czs007 pushed a commit that referenced this issue May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

1 participant