Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add a utility to convert channel name string comparison to int one #32748

Open
1 task done
congqixia opened this issue Apr 30, 2024 · 0 comments
Open
1 task done
Assignees
Labels
kind/enhancement Issues or changes related to enhancement

Comments

@congqixia
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

Add a utility to convert channel name string comparison to int one

Why is this needed?

InsertChannel comparison is common case in Milvus system. Since the string comparison is heavy, it's better to convert them into int operations

Anything else?

No response

@congqixia congqixia added the kind/enhancement Issues or changes related to enhancement label Apr 30, 2024
@congqixia congqixia self-assigned this Apr 30, 2024
congqixia added a commit to congqixia/milvus that referenced this issue Apr 30, 2024
See also milvus-io#32748

This PR:

- Add `metautil.Channel` utiltiy which convert virtual name to physical
  channel name, collectionID and shard idx
- Add channel mapper interface & implementation to convert limited
  physical channel name into int index
- Apply `metautil.Channel` filter in querynode segment manager logic

Signed-off-by: Congqi Xia <[email protected]>
congqixia added a commit to congqixia/milvus that referenced this issue May 6, 2024
See also milvus-io#32748

This PR:

- Add `metautil.Channel` utiltiy which convert virtual name to physical
  channel name, collectionID and shard idx
- Add channel mapper interface & implementation to convert limited
  physical channel name into int index
- Apply `metautil.Channel` filter in querynode segment manager logic

Signed-off-by: Congqi Xia <[email protected]>
congqixia added a commit to congqixia/milvus that referenced this issue May 6, 2024
See also milvus-io#32748

This PR:

- Add `metautil.Channel` utiltiy which convert virtual name to physical
  channel name, collectionID and shard idx
- Add channel mapper interface & implementation to convert limited
  physical channel name into int index
- Apply `metautil.Channel` filter in querynode segment manager logic

Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot pushed a commit that referenced this issue May 7, 2024
)

See also #32748

This PR:

- Add `metautil.Channel` utiltiy which convert virtual name to physical
channel name, collectionID and shard idx
- Add channel mapper interface & implementation to convert limited
physical channel name into int index
- Apply `metautil.Channel` filter in querynode segment manager logic

---------

Signed-off-by: Congqi Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Issues or changes related to enhancement
Projects
None yet
Development

No branches or pull requests

1 participant