Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: CreateIndex bypass DISKANN mmap constraint #32711

Closed
1 task done
congqixia opened this issue Apr 29, 2024 · 0 comments
Closed
1 task done

[Bug]: CreateIndex bypass DISKANN mmap constraint #32711

congqixia opened this issue Apr 29, 2024 · 0 comments
Assignees
@congqixia
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@congqixia
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: a43baa0
- Deployment mode(standalone or cluster): 
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

Create DiskANN with mmap enabled is allowed

Expected Behavior

An error shall be returned when create index with mmap attribute

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response
@congqixia congqixia added kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Apr 29, 2024
@congqixia congqixia self-assigned this Apr 29, 2024
congqixia added a commit to congqixia/milvus that referenced this issue Apr 29, 2024
@congqixia
fix: Refine index param check for Create/Alter Index
73329c4 
See also milvus-io#32711

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue Apr 29, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue May 6, 2024
@congqixia
fix: Refine index param check for Create/Alter Index (#32712)
6af5275 
See also #32711

Signed-off-by: Congqi Xia <[email protected]>
congqixia added a commit to congqixia/milvus that referenced this issue May 6, 2024
@congqixia
fix: Refine index param check for Create/Alter Index (milvus-io#32712)
b54ea1a 
See also milvus-io#32711

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue May 6, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue May 6, 2024
@congqixia
fix: [2.4] Refine index param check for Create/Alter Index (#32712) (#…
0fc6b22 
…32784)

Cherry-pick from master
pr: #32712
See also #32711

Signed-off-by: Congqi Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@congqixia congqixia

Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@congqixia