Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Unify Pulsar image #47

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Unify Pulsar image #47

merged 1 commit into from
Dec 1, 2021

Conversation

haorenfsa
Copy link
Contributor

@haorenfsa haorenfsa commented Nov 26, 2021

#51 use pulsar image instead of pulsar-all.

The pulsar-all only add puslar connectors & offloads in pulsar which will not be used in our deploy.

Ref: see diffs between pulsar-all image layers and pulsar image layers, line 23, 24

/cc @zwd1208

Signed-off-by: shaoyue.chen <[email protected]>
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #47 (aa3c3a5) into main (daad5b6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #47   +/-   ##
=======================================
  Coverage   28.70%   28.70%           
=======================================
  Files          19       19           
  Lines        1728     1728           
=======================================
  Hits          496      496           
  Misses       1223     1223           
  Partials        9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daad5b6...aa3c3a5. Read the comment docs.

@haorenfsa haorenfsa changed the title WIP: Optimize time of creating MilvusCluster Unify Pulsar image Dec 1, 2021
@zwd1208
Copy link
Collaborator

zwd1208 commented Dec 1, 2021

/lgtm

@sre-ci-robot sre-ci-robot merged commit 43dff80 into milvus-io:main Dec 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants