Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Supports natsmq #273

Closed
wants to merge 1 commit into from
Closed

Supports natsmq #273

wants to merge 1 commit into from

Conversation

haorenfsa
Copy link
Contributor

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa, mintcckey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mintcckey
Copy link
Contributor

/lgtm

@sre-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #273 (cca07a7) into main (daa1cbf) will decrease coverage by 0.03%.
The diff coverage is 73.68%.

❗ Current head cca07a7 differs from pull request most recent head d8f3d15. Consider uploading reports for the commit d8f3d15 to get more accurate results

@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
- Coverage   80.05%   80.02%   -0.03%     
==========================================
  Files          46       46              
  Lines        4707     4721      +14     
==========================================
+ Hits         3768     3778      +10     
- Misses        795      798       +3     
- Partials      144      145       +1     
Files Changed Coverage Δ
pkg/controllers/dependencies.go 82.45% <0.00%> (ø)
pkg/controllers/pvc.go 95.23% <25.00%> (-4.77%) ⬇️
pkg/controllers/configmaps.go 64.42% <83.33%> (+1.53%) ⬆️
apis/milvus.io/v1beta1/milvus_types.go 75.65% <100.00%> (+1.57%) ⬆️
pkg/controllers/deployment_updater.go 87.67% <100.00%> (-0.17%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: shaoyue.chen <[email protected]>
@haorenfsa
Copy link
Contributor Author

haorenfsa commented Aug 15, 2023

move to zilliztech/milvus-operator#4

@haorenfsa haorenfsa closed this Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants