Skip to content
This repository has been archived by the owner on Aug 16, 2023. It is now read-only.

Fix Distance.cu bitset idx match #896

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kayang-potato
Copy link

When running a batch, the bitset match is incorrect.

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kayang-potato
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot requested review from hhy3 and liliu-z May 21, 2023 16:37
@mergify mergify bot added the dco-passed DCO check passed. label May 21, 2023
@mergify
Copy link

mergify bot commented May 21, 2023

@kayang-potato Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@cydrain
Copy link
Collaborator

cydrain commented May 22, 2023

Hi @kayang-potato ,
By now knowhere only supports RAFT GPU index, Faiss GPU index has not been compiled in knowhere.
How did you find this issue ?

@mergify mergify bot added the ci-passed label May 22, 2023
@cydrain
Copy link
Collaborator

cydrain commented May 23, 2023

/hold

@kayang-potato
Copy link
Author

Hi @kayang-potato , By now knowhere only supports RAFT GPU index, Faiss GPU index has not been compiled in knowhere. How did you find this issue ?

image

您好,这张CMakelists中表明除了RAFT GPU index,knowhere还编译了Flat GPU,而该索引search的底层调用了thirdparty/faiss/faiss/gpu/impl/Distance.curunDistance函数,该函数错误地使用了bitset,麻烦再关注一下,感谢!

@cydrain
Copy link
Collaborator

cydrain commented May 26, 2023

Hi @kayang-potato , By now knowhere only supports RAFT GPU index, Faiss GPU index has not been compiled in knowhere. How did you find this issue ?

image

您好,这张CMakelists中表明除了RAFT GPU index,knowhere还编译了Flat GPU,而该索引search的底层调用了thirdparty/faiss/faiss/gpu/impl/Distance.curunDistance函数,该函数错误地使用了bitset,麻烦再关注一下,感谢!

The line 108 means, removing ${KNOWHERE_GPU_SRCS} from ${KNOWHERE_SRCS}

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants