chore(mock): check process.env.MIDWAY_HTTP_PORT #3599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czy88840616
reviewed
Jan 27, 2024
| @@ -21,9 +21,14 @@ const { join } = require('path'); | |||
| ...args, | |||
| }); | |||
|
|
|||
| const port = process.env.MIDWAY_HTTP_PORT | |||
| if (! port) { | |||
There was a problem hiding this comment.
这个不一定有，比如纯 grpc 服务就没有 http port 了
There was a problem hiding this comment.
是的，挺奇怪的，相同的配置参数 （ run dev ） , 命令行启动正常。而在 vscode 的 F5 启动就卡住，排查下来就是没有配置端口导致的。
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3599 +/- ##
==========================================
- Coverage 84.45% 84.37% -0.09%
==========================================
Files 491 491
Lines 46730 46730
Branches 5584 5566 -18
==========================================
- Hits 39468 39427 -41
- Misses 7221 7262 +41
Partials 41 41 ☔ View full report in Codecov by Sentry. |
czy88840616
added
the
status: Holding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
检查
process.env.MIDWAY_HTTP_PORT变量是否设置。有时卡着一直启动不了，不出现
➜ Local: http://127.0.0.1:7001/的信息，也没有日志可以判断。