Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: file grid #2564

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

feat: file grid #2564

wants to merge 37 commits into from
+3,820 −827

Conversation

gavinbarron
Copy link
Member

Closes #

PR Type

  • Feature

Description of the changes

Adds a file grid view with per item context menus to perform file actions

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

Replacement for #2057

@gavinbarron
feat: add breadcrumb and folder navigation to file list
02f4ec6
@gavinbarron
Merge branch 'next/enhanced-file-list' into feat/file-list-enhancements
ef3227f
@gavinbarron
feat: theme toggle control
b769f39 
adds a new component to allow switching in the ui between light and dark modes
adds a theme toggle to all stories by default
updates developer test page to include toggle
adds helper functions to assist with theme changing using fluentui web components theming tools
@gavinbarron
feat: add generic breadcrumb component
6149a58
@gavinbarron
renamed toggle component
a4d4c0e
@gavinbarron
fixing broken stories
badd280
@gavinbarron
added copyright headers and adjusted theme names to account for Teams
1d08034
@gavinbarron
merging theme toggle
f539707
@gavinbarron
refactored breadcrumb to separate component, added styling
4e263f8
@gavinbarron
adds tests for breadcrumb
f6f6106
@gavinbarron
Merge remote-tracking branch 'origin/next/fluentui' into feat/file-li…
19a0064 
…st-enhancements
@gavinbarron
added basic story for file composite
bb0763f
@gavinbarron
merge from next/fluentui
e2fbf68
@gavinbarron
fixes story name and heirachy placement
ebe30f0
@gavinbarron
adding stories for file composite and breadcrumb
4b65582
@gavinbarron
fixing property bindings on file-list
d04bbb9
@gavinbarron
feat: file-grid
4672407 
adds a file grid option to the file-list-composite
@gavinbarron
refactor: move file dialogs up to composite
d3c6561
@gavinbarron
Merge branch 'main' into merge/from-main
90aa651
@gavinbarron
adding reload logic to rename process
b9de2aa
@gavinbarron
adding file-grid and file-composite to react components
5771ab4
@gavinbarron
fixing generation for arbirary generic types in mgt-components
745c164
@gavinbarron
need to ensure Command is exported
0fb1ed9
@gavinbarron
resolving conflicts
2de2c03
@gavinbarron
adding file grid to composite stories
e3b0a65
@gavinbarron
wip
39f73f4
@gavinbarron
fixing breadcrumb logic to preserve driveId when navigating through f…
2851f8d 
…olders
@gavinbarron
merge from next/fluentui
e6fdc87
@gavinbarron
fix to account for React wrapper not setting props before connectedCa…
c4830fa 
…llback occurs
@gavinbarron
adding command bar for file upload and new folder commands
48046d0
@gavinbarron gavinbarron requested a review from a team as a code owner June 27, 2023 16:26
@ghost
Copy link

ghost commented Jun 27, 2023

Thank you for creating a Pull Request @gavinbarron.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@sebastienlevert sebastienlevert mentioned this pull request Nov 23, 2023
Closed
@eduardpaul
Copy link

Wow really was looking for something like this. Hope to se it soon in main branch.

@sebastienlevert
Copy link
Contributor

If you want to help and complete the PR, we'd gladly provide support to bring this feature across the finish line!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
8.4% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@sebastienlevert sebastienlevert mentioned this pull request May 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Build: Storybook
Projects
Graph Toolkit
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gavinbarron @eduardpaul @sebastienlevert @Mnickii