Update olive configs to match new format #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaysabelle
changed the title
kaysabelle
commented
May 10, 2024
| "accelerators": [ | ||
| { | ||
| "device": "gpu", | ||
| "execution_providers": ["CPUExecutionProvider"] |
There was a problem hiding this comment.
Is this the right place for this?
kaysabelle
commented
May 10, 2024
| "accelerators": ["gpu"] | ||
| } | ||
| }, | ||
| "execution_providers": ["CPUExecutionProvider"], |
There was a problem hiding this comment.
Wasn't sure where to add this property, should it stay here in this section?
kaysabelle
commented
May 10, 2024
| @@ -2,16 +2,46 @@ | |||
| "input_model":{ | |||
| "type": "PyTorchModel", | |||
| "config": { | |||
| "model_script": "finetuning/qlora_user_script.py", | |||
| "io_config": "get_merged_decoder_with_past_io_config", | |||
| "dummy_inputs_func": "get_merged_decoder_with_past_dummy_inputs", | |||
There was a problem hiding this comment.
These 3 lines are the same across all files. The model_script property seems necessary, but are the other 2 (io_config and dummy_inputs_func) needed?
kaysabelle
commented
May 10, 2024
| @@ -50,7 +50,7 @@ | |||
| { | |||
| "providerType": "HuggingFace", | |||
| "modelId": "microsoft/phi-2", | |||
| "revision": "d3186761bf5c4409f7679359284066c25ab668ee" | |||
| "revision": "main" | |||
There was a problem hiding this comment.
Not sure if we still need this change?
vriveras
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested these locally by pointing my extension to pull the templates from my branch.
Successfully tested local finetuning for:
✅ phi-2
✅ phi-1-5
✅ phi-3
✅ zephyr-7b-beta
✅ llama-2-7b
Could not test:
❌ mistral-7b
I was not able to test mistral-7b as I don't have access permission to Llama2 models (tried signing up on the ONNX sign up page):