Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instantiate status bar contribs with services scoped to the window #211997

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amunger
Copy link
Contributor

@amunger amunger commented May 3, 2024

fix #210383

current issues:

  • line ending status bar contrib leaks over into the notebook editor now
  • sometimes duplicate status items are added to the notebook editor in the main window when a text editor is open in the aux window
  • status bar items are not re-added on reload, I'm not sure how this works for text editors

@bpasero
Copy link
Member

bpasero commented May 4, 2024

There is a IEditorGroupService.onDidCreateAuxiliaryEditorPart event that editor status listens to to create status:

// Auxiliary Editor Status
this._register(editorGroupService.onDidCreateAuxiliaryEditorPart(({ part, instantiationService, disposables }) => {
disposables.add(instantiationService.createInstance(EditorStatus, part.windowId));
}));

That should be called on startup when aux windows are restored and can be used to restore notebook status if thats an active editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notebook: status bar is not floating window aware
2 participants