Pass full function breakpoint options from plugin #211895
Merged
+24
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@microsoft-github-policy-service agree |
OccasionalDebugger
force-pushed
the
improvement/more-function-breakpoint-parameters
branch
from
abc097c
to
8ca50f2
Compare
OccasionalDebugger
force-pushed
the
improvement/more-function-breakpoint-parameters
branch
from
872f095
to
47ce46b
Compare
roblourens
reviewed
May 8, 2024
| @@ -223,7 +223,14 @@ export class MainThreadDebugService implements MainThreadDebugServiceShape, IDeb | |||
| })); | |||
| this.debugService.addBreakpoints(uri.revive(dto.uri), rawbps); | |||
| } else if (dto.type === 'function') { | |||
| this.debugService.addFunctionBreakpoint(dto.functionName, dto.id, dto.mode); | |||
| this.debugService.addFunctionBreakpoint({ | |||
There was a problem hiding this comment.
This seems fine, right @connor4312? I don't know why it would have been limited
There was a problem hiding this comment.
yea, I don't either. This limitation dates from eba681f and I think it's just a bug.
connor4312
approved these changes
May 8, 2024
TylerLeonhardt
approved these changes
May 8, 2024
|
Thanks for the PR! |
SimonSiefke
pushed a commit
to SimonSiefke/vscode
that referenced
this pull request
May 8, 2024
* Pass full function breakpoint options from plugin * Send newly added function breakpoints to DA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #211894 by modifying the chain of calls to create a new function breakpoint to accept the full range of configurable fields. This ensures that the inserted function breakpoint matches the specification provided by a plugin rather than ignoring a variety of fields.
While working on this, I noticed #209386, and I have added code to send well-formed function breakpoints at the time of their creation, so this also fixes #209386.