Allow vscode-api-tests to be picked up by Extension Test Runner #211656
+17
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also called out behavior difference.
connor4312
reviewed
Apr 29, 2024
| mocha: { timeout: 60_000 } | ||
| }, | ||
| { | ||
| label: 'vscode-api-tests', |
There was a problem hiding this comment.
I don't think the test runner right now handles multiple configurations with the same label; yarn test-extension -l vscode-api-tests is probably just running the first declaration of those tests. We should probably throw a more explicit error.
There was a problem hiding this comment.
In my experience it runs tests twice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also called out behavior difference.