Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add selection to next find match (CTRD + D) not working with Regex Find Mode (#107090) #211550

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

BrunoSoaresEngineering
Copy link
Contributor

Solves #107090 .

Solved by passing isRegex flag from findController to MultiCursorSession as much like the wholeWord and matchCase flags.

Added unit test to specifically test this issue. While writing the unit test, I identified another potential issue: while adding selection to next find match using the find controller, the selection range that was there, previous to the change of focus to the find input box, is not released. That is the reason I had to add the [1, 1, 1, 1] range to the expected selections array in the unit test assertion. Since this issue has a different root cause, I am opening a new issue to tackle this separately.

I appreciate a lot your feedback in advance,

@BrunoSoaresEngineering
Copy link
Contributor Author

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants