Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook: status bar is not floating window aware #210383

Open
bpasero opened this issue Apr 15, 2024 · 0 comments · May be fixed by #211997
Open

Notebook: status bar is not floating window aware #210383

bpasero opened this issue Apr 15, 2024 · 0 comments · May be fixed by #211997
Assignees
@rebornix @amunger
Labels
bug Issue identified by VS Code Team member as probable bug notebook workbench-auxwindow Issues related to use of auxiliary ("floating") windows.
Milestone
May 2024

Comments

@bpasero
Copy link
Member

bpasero commented Apr 15, 2024

This is a missing adoption when notebooks became floating window capable. Notice how the status bar entry appears in the main window and not the floating window:

Screenshot 2024-04-15 at 11 56 20

We have had a similar issue with the text editor status bar and solved it by instantiating it per-window:

vscode/src/vs/workbench/browser/parts/editor/editorStatus.ts

Lines 895 to 904 in b41db61

// Main Editor Status
const mainInstantiationService = instantiationService.createChild(new ServiceCollection(
[IEditorService, editorService.createScoped('main', this._store)]
));
this._register(mainInstantiationService.createInstance(EditorStatus, mainWindow.vscodeWindowId));
// Auxiliary Editor Status
this._register(editorGroupService.onDidCreateAuxiliaryEditorPart(({ part, instantiationService, disposables }) => {
disposables.add(instantiationService.createInstance(EditorStatus, part.windowId));
}));

I think a similar approach would work for notebooks too.

The key for this to work is that you get a scoped IEditorService in the onDidCreateAuxiliaryEditorPart that allows you to listen only to editor change events in the respective window. Consequently, you use a main-window scoped editor service for the main-window status bar:

vscode/src/vs/workbench/browser/parts/editor/editorStatus.ts

Line 897 in b41db61

[IEditorService, editorService.createScoped('main', this._store)]

Let me know if you have questions, but I think its easy to copy what we do for editor status here.
@bpasero bpasero added notebook workbench-auxwindow Issues related to use of auxiliary ("floating") windows. labels Apr 15, 2024
@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Apr 23, 2024
@rebornix rebornix added this to the May 2024 milestone Apr 23, 2024
@amunger amunger linked a pull request May 3, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rebornix rebornix

@amunger amunger

Labels
bug Issue identified by VS Code Team member as probable bug notebook workbench-auxwindow Issues related to use of auxiliary ("floating") windows.
Projects
None yet
Milestone
May 2024
Development

Successfully merging a pull request may close this issue.

instantiate status bar contribs with services scoped to the window microsoft/vscode
3 participants
@rebornix @bpasero @amunger