Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libfaketime] Add new port #38490

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

[libfaketime] Add new port #38490

wants to merge 10 commits into from

Conversation

dudoslav
Copy link

@dudoslav dudoslav commented Apr 30, 2024

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@dudoslav
Copy link
Author

@microsoft-github-policy-service agree company="TileDB"

@Cheney-W Cheney-W added the category:new-port The issue is requesting a new library to be added; consider making a PR! label May 6, 2024
@Cheney-W
Copy link
Contributor

Cheney-W commented May 6, 2024

0.9.10 is declared with 451debe90ea3a82a03d3ba30eeaa0abc3e9409a3, but the local port has a different SHA 43c3d525b4e071c4265c512fda07775af3a0df6a.
Please update the port's version fields and then run:
vcpkg x-add-version libfaketime
git add versions
git commit -m "Update version database"
to add the new version.
To attempt to resolve all errors at once, run:
vcpkg x-add-version --all

@Cheney-W Cheney-W marked this pull request as draft May 6, 2024 10:07
@Cheney-W Cheney-W changed the title Add libfaketime [libfaketime] Add new port May 6, 2024
@Cheney-W
Copy link
Contributor

Cheney-W commented May 6, 2024

Why don't you use the Makefile provided by the upstream to build this port?

@dudoslav
Copy link
Author

For our use case only libfaketime.so is needed and I prefer using CMake. I hope it is not an issue :) .

@Cheney-W
Copy link
Contributor

The vcpkg policy is that if the upstream provides multiple build methods, we prefer CMake. However, if the upstream only provides one available build method, we need to use the upstream's build method instead of using a custom CMake.

@dudoslav
Copy link
Author

I reworked this PR to use Make instead of CMake but right now it fails due to I assume incorrect working directory, is there a chance to change it?:

-- Building x64-linux-dbg
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:134 (message):
    Command failed: /usr/bin/make V=1 -j 9 -f Makefile all
    Working Directory: /home/dudoslav/Projects/vcpkg/buildtrees/libfaketime/x64-linux-dbg/
    See logs for more information:
      /home/dudoslav/Projects/vcpkg/buildtrees/libfaketime/build-x64-linux-dbg-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_build_make.cmake:136 (vcpkg_execute_build_process)
  scripts/cmake/vcpkg_install_make.cmake:2 (vcpkg_build_make)
  ports/libfaketime/portfile.cmake:10 (vcpkg_install_make)
  scripts/ports.cmake:175 (include)


error: building libfaketime:x64-linux failed with: BUILD_FAILED
Elapsed time to handle libfaketime:x64-linux: 1.7 s
Please ensure you're using the latest port files with `git pull` and `vcpkg update`.
Then check for known issues at:
  https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+libfaketime
You can submit a new issue at:
  https://github.com/microsoft/vcpkg/issues/new?title=[libfaketime]+Build+error+on+x64-linux&body=Copy+issue+body+from+%2Fhome%2Fdudoslav%2FProjects%2Fvcpkg%2Finstalled%2Fvcpkg%2Fissue_body.md

(base) taco:vcpkg dudoslav$ cat /home/dudoslav/Projects/vcpkg/buildtrees/libfaketime/build-x64-linux-dbg-err.log
───────┬────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
       │ File: /home/dudoslav/Projects/vcpkg/buildtrees/libfaketime/build-x64-linux-dbg-err.log
───────┼────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   1   │ make: Makefile: No such file or directory
   2   │ make: *** No rule to make target 'Makefile'.  Stop.
───────┴────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
(base) taco:vcpkg dudoslav$ 

1716209136_grim
But I can see that the source is in src instead of /home/dudoslav/Projects/vcpkg/buildtrees/libfaketime/x64-linux-dbg/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should delete this file and revert the changes to baseline.json, run vcpkg x-add-version, and make and push a commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants