Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libclocale] Initial Port #38489

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

eyalgolan1337
Copy link

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@LilyWangLL LilyWangLL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label May 6, 2024
@LilyWangLL
Copy link
Contributor

Pinging @eyalgolan1337 for response. Is work still being done for this PR? There are conflicts error on CI pipeline as below.

Installing 9/9 libclocale:x86-windows@20240414...
Building libclocale:x86-windows@20240414...
-- Downloading https://github.com/libyal/libclocale/releases/download/20240414/libclocale-alpha-20240414.tar.gz -> libclocale-alpha-20240414.tar.gz...
-- Extracting source D:/downloads/libclocale-alpha-20240414.tar.gz
-- Using source at D:/b/libclocale/src/a-20240414-f70f96bd93.clean
-- Using cached libyal-vstools-f412b5f4347839c31a6f7ff2a631990f84d81b40.tar.gz.
-- Extracting source D:/downloads/libyal-vstools-f412b5f4347839c31a6f7ff2a631990f84d81b40.tar.gz
-- Using source at D:/b/libclocale/src/0f84d81b40-78707ee12a.clean
-- Found external ninja('1.11.0').
-- Getting CMake variables for x86-windows
-- Building vs2022/libclocale.sln for Release
-- Building vs2022/libclocale.sln for Debug
-- Installing: D:/p/libclocale_x86-windows/include/libclocale/definitions.h
-- Installing: D:/p/libclocale_x86-windows/include/libclocale/error.h
-- Installing: D:/p/libclocale_x86-windows/include/libclocale/extern.h
-- Installing: D:/p/libclocale_x86-windows/include/libclocale/features.h
-- Installing: D:/p/libclocale_x86-windows/include/libclocale/types.h
-- Installing: D:/p/libclocale_x86-windows/include/libclocale.h
-- Installing: D:/p/libclocale_x86-windows/share/unofficial-libclocale/unofficial-libclocale-config.cmake
-- Installing: D:/p/libclocale_x86-windows/share/libclocale/copyright
-- Performing post-build validation
error: The following files are already installed in D:/installed/x86-windows and are in conflict with libclocale:x86-windows
Installed by libcerror:x86-windows  
debug/lib/libcerror.lib
    lib/libcerror.lib

You can get the more logs from https://dev.azure.com/vcpkg/public/_build/results?buildId=102483&view=logs&jobId=878666d5-db33-5b27-9e7d-b0c7ee352005&j=878666d5-db33-5b27-9e7d-b0c7ee352005&t=dc897974-8f7e-5107-e5db-0a01be8e9d4f, could you please resolve this error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants