[luafilesystem] Add cmake files #38425
Open
+74
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have prior experience with creating Config files, so extra attention in the review may be warranted. |
FrankXie05
added
the
category:port-feature
FrankXie05
previously approved these changes
Apr 29, 2024
dg0yt
reviewed
Apr 29, 2024
TheCycoONE
force-pushed
the
lua_mod_cmake
branch
5 times, most recently
from
b74e133
to
432a7ef
Compare
|
Ready for review again |
I used the name LFS after the conventional name of the dll/so file the package ships, e.g. https://archlinux.org/packages/extra/x86_64/lua-filesystem/ I don't mind changing it if the package name is better, but the target library name made sense to me; as that's what projects that have multiple targets like ffmpeg do. Are there other cases where the package name and the dll/so name don't match to look at? Edit: |
|
Applied recommended changes, and added usage file. |
Addresses microsoft#38340 for luafilesystem
FrankXie05
approved these changes
May 20, 2024
FrankXie05
added
the
requires:all-feature-testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of two ports for #38340
[ ] SHA512s are updated for each updated download.[ ] The "supports" clause reflects platforms that may be fixed by this new version.[ ] Any fixed CI baseline entries are removed from that file.[ ] Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --alland committing the result.