Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg-cmake] get more logs #38409

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

[vcpkg-cmake] get more logs #38409

wants to merge 5 commits into from
+26 −4

Conversation

Neumann-A
Copy link
Contributor

No description provided.

dg0yt
dg0yt suggested changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMakeConfigureLog.yaml is great.

Note that another change to this port is pending in #38249.

ports/vcpkg-cmake/vcpkg_cmake_configure.cmake Outdated Show resolved Hide resolved
@dg0yt
Copy link
Contributor

dg0yt commented Apr 25, 2024

And IIUC all these logs become part of the GH issues.

@FrankXie05 FrankXie05 added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Apr 25, 2024
@dg0yt
Copy link
Contributor

dg0yt commented Apr 25, 2024

meson and gn use ninja, too. At which point will "build with ninja" be generalized?

@Neumann-A
Copy link
Contributor Author 

REGRESSION: openmvs:x64-windows-static failed with BUILD_FAILED. If expected, add openmvs:x64-windows-static=fail to D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: rtabmap:x64-windows-static failed with BUILD_FAILED. If expected, add rtabmap:x64-windows-static=fail to D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt.

are baseline due to the removal of CBLAS_LIBRARIES from the lapack-wrapper is fixed in the VTK PR

@Neumann-A Neumann-A mentioned this pull request Apr 29, 2024
Closed
7 tasks
@Neumann-A
Copy link
Contributor Author

Neumann-A commented Apr 30, 2024 •
edited

I wouldn't mind SAVE_LOG_FILES to be exposed to the caller somehow. Maybe some Z_VCPKG_ variable would make sense here? The main use is debugging especially for the build.ninja file.

(CMakeConfigureLog.yaml should always be parts of the logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt requested changes

Assignees

@FrankXie05 FrankXie05

Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Neumann-A @dg0yt @FrankXie05