Refactor ActionMap and Command to use ActionIDs #17162
Conversation
| { | ||
| if (cmd.ActionAndArgs().Action() != ShortcutAction::Invalid) | ||
| // Only populate AvailableActions with actions that haven't been visited already. | ||
| const auto actionID = Hash(cmd.ActionAndArgs()); |
There was a problem hiding this comment.
Unfortunately we still have to use InternalActionID to populate the available action dropdown in the SUI since we don't have a Terminal.<> id for every configuration of each shortcut action and its args
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
| else | ||
| { | ||
| // this is not a command block, so it is a keybinding block | ||
| _AddKeyBindingHelper(jsonBlock, warnings); |
There was a problem hiding this comment.
If you invert the if condition, you can flip the branches and use continue here. It would still make sense that way IMO, because it would read "if it has no commands and no actions, then add an error and continue".
There was a problem hiding this comment.
We're not adding errors here, we're either adding a keybinding or adding an action (that may have a keybinding in it if it is the legacy style)
|
Summary of the Pull Request
As outlined in #16816, refactor
ActionMapto use the new action IDs added in #16904Detailed description of the pull request
See the spec!
Validation steps performed
References and Relevant Issues
#16816
PR Checklist