Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the location that selecting a mark uses #17138

Merged
merged 2 commits into from May 1, 2024

Commits on Apr 26, 2024

  1. Fix the location that selecting a mark uses

    I think this subtly regressed in
    
    `Terminal::SelectNewRegion` is the only thing that uses the return value from
    `Terminal::_ScrollToPoints`. Before that PR, `_ScrollToPoints` was just a part
    of `SelectNewRegion`, and it moved the start & end coords by the
    `_VisibleStartIndex`, not the `_scrollOffset`.
    
    Kinda weird there weren't any _other_ tests for `SelectNewRegion`?
    
    I also caught a second bug while I was here - If you had a line with an exact
    wrap, and tried to select that like with selectOutput, we'd explode.
    
    Closes #17131
    zadjii-msft committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    aa74f45 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Configuration menu
    Copy the full SHA
    2bf1f34 View commit details
    Browse the repository at this point in the history