Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update libpopcnt to v2.6 #17098

Closed
wants to merge 3 commits into from
Closed

Update libpopcnt to v2.6 #17098

wants to merge 3 commits into from

Conversation

Jvr2022
Copy link
Contributor

@Jvr2022 Jvr2022 commented Apr 22, 2024

No description provided.

DHowett
DHowett requested changes Apr 22, 2024
View reviewed changes
oss/libpopcnt/libpopcnt.h Outdated Show resolved Hide resolved
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Apr 22, 2024
zadjii-msft
zadjii-msft requested changes Apr 24, 2024
View reviewed changes
oss/libpopcnt/libpopcnt.h Outdated Show resolved Hide resolved
oss/libpopcnt/libpopcnt.h Outdated Show resolved Hide resolved
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 24, 2024
@Jvr2022
Copy link
Contributor Author

Jvr2022 commented Apr 25, 2024

fixed

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Apr 25, 2024
@lhecker
Copy link
Member

lhecker commented Apr 25, 2024

The build macro aside, do we actually need to update this? The only change is for fixing the build on NetBSD, which I'm pretty sure Windows Terminal will never support. 😅

@zadjii-msft
Copy link
Member

After some team discussion, we've come to the conclusion that we don't really think we can accept this PR right now. There's some pending internal work that we need to do to get all our OSS dependencies moved over to vcpkg (ala #15855). We can update OSS dependencies, but there's quite a lot of extra (internal) process at this time, that it doesn't make sense to continually ingest small version bumps that don't have any product-critical fixes in them. Considering the only change here is "Fix building on NetBSD" (https://github.com/kimwalisch/libpopcnt/releases/tag/v2.6), that's not really relevant to our product code 🤷

@zadjii-msft zadjii-msft mentioned this pull request Apr 30, 2024
Closed
@Jvr2022
Copy link
Contributor Author

Jvr2022 commented Apr 30, 2024

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett requested changes

@zadjii-msft zadjii-msft zadjii-msft requested changes

Assignees
No one assigned
Labels
Needs-Attention The core contributors need to come back around and look at this ASAP.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Jvr2022 @lhecker @zadjii-msft @DHowett