Add files via upload #17037
Closed
Add files via upload #17037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zadjii-msft
requested changes
Apr 23, 2024
| @@ -187,6 +187,9 @@ | |||
| <data name="Quit" xml:space="preserve"> | |||
| <value>Quit</value> | |||
| </data> | |||
| <data name="CloseWindowWarningTitle" xml:space="preserve"> | |||
There was a problem hiding this comment.
This resource seems to not be used anywhere?
| @@ -215,10 +218,10 @@ | |||
| <value>Web search</value> | |||
| </data> | |||
| <data name="TabColorChoose" xml:space="preserve"> | |||
| <value>Change tab color</value> | |||
| <value>Color...</value> | |||
There was a problem hiding this comment.
isn't this literally the opposite of what was done in #16886
| </data> | ||
| <data name="TabColorCustomButton.Content" xml:space="preserve"> | ||
| <value>Custom</value> | ||
| <value>Custom...</value> |
| @@ -835,7 +835,7 @@ | |||
| <value>Close this tab</value> | |||
| </data> | |||
| <data name="NewTabMenuFolderEmpty" xml:space="preserve"> | |||
| <value>Empty</value> | |||
| <value>Empty...</value> | |||
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
I think what happened here is that lsmith took a snapshot of the file as it was when they started working, and re-uploaded it via the GitHub web UI after they made their modifications. If that's the case - there are some changes that need to be integrated from #16886! |
microsoft-github-policy-service
bot
added
Needs-Attention
|
Okay we looked over it all again - looks like #16886 took care of things here. Thanks anyways! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Edited Resources.resw to reflect the style guidlines
References and Relevant Issues
Issue #16846
Detailed Description of the Pull Request / Additional comments
Edited Resources.resw to reflect the desired style guidelines. Specifically sentence style capitalization and use of elipses.
Validation Steps Performed
PR Checklist