Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick copy/Quick jump #16929

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Quick copy/Quick jump #16929

wants to merge 1 commit into from

Conversation

e82eric
Copy link
Contributor

@e82eric e82eric commented Mar 25, 2024

Summary of the Pull Request

WezTerm has a Quick Select feature that allows you to specify a regex to find patterns within the buffer and quickly copy or navigate to the matches using alphabet hints.
https://wezfurlong.org/wezterm/quickselect.html

I added a implementation of this to my personal build and find that I use it for almost every copy/navigation operation.

  • For my configs I defined 2 regexs, 1 for words and one for lines which seems to cover everything that I would want to do but it is nice to have the flexibility to define specific ones for stuff like hashes and addresses

In its current state I don't think that it makes sense to merge this. But if you do decide to add something like this, I would love to work on it.

QuickSelect

Configs that I use.

{
  "command": 
  {
    "action": "quickSelect",
    "input": "[\\w\\d\\S]+",
    "shouldCopy": true
  },
  "keys": "alt+shift+space",
  "name": "Quick Copy Word"
},
{
  "command": 
  {
    "action": "quickSelect",
    "input": "[\\w\\d\\S]+"
  },
  "keys": "alt+space",
  "name": "Quick Jump Word"
},
{
  "command": 
  {
    "action": "quickSelect",
      "input": ".*\\S",
      "shouldCopy": false
  },
    "keys": "alt+l",
    "name": "Quick Jump Line"
},
{
  "command": 
  {
    "action": "quickSelect",
    "input": ".*\\S",
    "shouldCopy": true
  },
  "keys": "alt+shift+l",
  "name": "Quick Copy Line"
},

References and Relevant Issues

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

PR Checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated
    • If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated (if necessary)

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (2)

colorref
Wrappable

Previously acknowledged words that are now absent AAAa COLORREFs 🫥
To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the [email protected]:e82eric/terminal.git repository
on the quick-select branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.22/apply.pl' |
perl - 'https://github.com/microsoft/terminal/actions/runs/8416355226/attempts/1'
Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (2222) from .github/actions/spelling/expect/04cdb9b77d6827c0202f51acd4205b017015bfff.txt
.github/actions/spelling/expect/alphabet.txt
.github/actions/spelling/expect/expect.txt
.github/actions/spelling/expect/web.txt and unrecognized words (2)

Dictionary Entries Covers Uniquely
cspell:swift/src/swift.txt 53 1 1
cspell:gaming-terms/dict/gaming-terms.txt 59 1 1
cspell:monkeyc/src/monkeyc_keywords.txt 123 1 1
cspell:cryptocurrencies/cryptocurrencies.txt 125 1 1
cspell:scala/dict/scala.txt 153 1 1

Consider adding them (in .github/workflows/spelling2.yml) for uses: check-spelling/[email protected] in its with:

      with:
        extra_dictionaries:
          cspell:swift/src/swift.txt
          cspell:gaming-terms/dict/gaming-terms.txt
          cspell:monkeyc/src/monkeyc_keywords.txt
          cspell:cryptocurrencies/cryptocurrencies.txt
          cspell:scala/dict/scala.txt

To stop checking additional dictionaries, add (in .github/workflows/spelling2.yml) for uses: check-spelling/[email protected] in its with:

check_extra_dictionaries: ''
Errors (1)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ ignored-expect-variant 3

See ❌ Event descriptions for more information.

✏️ Contributor please read this

By default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.

If the listed items are:

  • ... misspelled, then please correct them instead of using the command.
  • ... names, please add them to .github/actions/spelling/allow/names.txt.
  • ... APIs, you can add them to a file in .github/actions/spelling/allow/.
  • ... just things you're using, please add them to an appropriate file in .github/actions/spelling/expect/.
  • ... tokens you only need in one place and shouldn't generally be used, you can add an item in an appropriate file in .github/actions/spelling/patterns/.

See the README.md in each directory for more information.

🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@carlos-zamora carlos-zamora added the Needs-Discussion Something that requires a team discussion before we can proceed label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Discussion Something that requires a team discussion before we can proceed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants