[clang-tidy] Remove in-product uses of std::bind #16870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes were automatically generated by clang-tidy. ``` clang-tidy --checks=modernize-avoid-bind --fix ```
lhecker
approved these changes
Mar 13, 2024
zadjii-msft
approved these changes
Mar 18, 2024
| @@ -98,28 +98,28 @@ namespace winrt::Microsoft::Terminal::Control::implementation | |||
| // GH#8969: pre-seed working directory to prevent potential races | |||
| _terminal->SetWorkingDirectory(_settings->StartingDirectory()); | |||
|
|
|||
| auto pfnCopyToClipboard = std::bind(&ControlCore::_terminalCopyToClipboard, this, std::placeholders::_1); | |||
| auto pfnCopyToClipboard = [this](auto&& PH1) { _terminalCopyToClipboard(std::forward<decltype(PH1)>(PH1)); }; | |||
There was a problem hiding this comment.
I was tempted to replace all these Terminal callbacks with til::event now that we can use that in the core lib, but this is also better than before
There was a problem hiding this comment.
Nah, til::event is only suitable for WinRT stuff. I don’t think we need to construct a whole whatever gets constructed for WinRT event invocations for something like these.
In fact, I am planning on moving ControlCore and Interactivity themselves away from WinRT!
lhecker
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were automatically generated by clang-tidy.
I have not bothered with the test code.