chore: Update to TAEF 10.88.240110002

[DHowett]

No description provided.

[DHowett]

I'm running this PR through the PGO build as well -- i will merge when it is done. @lhecker @zadjii-msft I need a re-review on the last push

[DHowett]

This test failure on ARM64 is durable (it keeps failing) and nonsensical.

terminal/src/buffer/out/ut_textbuffer/TextAttributeTests.cpp

Lines 116 to 127 in d3a18b9

	const auto& colorTable = _renderSettings.GetColorTable();
	const auto red = RGB(255, 0, 0);
	const auto faintRed = RGB(127, 0, 0);
	const auto green = RGB(0, 255, 0);
	TextAttribute attr(red, green);
	// verify that calculated foreground/background are the same as the direct
	// values when reverse video is not set
	VERIFY_IS_FALSE(attr.IsReverseVideo());
	VERIFY_ARE_EQUAL(red, attr.GetForeground().GetColor(colorTable, _defaultFgIndex));
	VERIFY_ARE_EQUAL(green, attr.GetBackground().GetColor(colorTable, _defaultBgIndex));

Line 127 is failing, because GetColor is returning #0C0C0C instead of #00FF00. We just constructed the attribute with green as the background index above.

I need to look at this on an actual ARM64 device...

[DHowett]

Also it only fails in release.

Figures.

[DHowett]

I am starting to suspect an ARM64 code generation issue.

attr.GetBackground().GetColor(...) optimizes down into a direct load of index 0 from the color table.

This is after the entire attribute is const-initialized to for sure be IsRGB.

[DHowett]

Here's a less red-yarn-and-thumbtacks image of the comparison and data flow

[zadjii-msft]

Did we ever file an internal issue on the ARM codegen thing here?

[lhecker]

I believe it's this one: https://developercommunity.visualstudio.com/t/Bad-ARM64-codegen--maybe-during-constant/10583372

[zadjii-msft]

got it, so that's https://task.ms/dd/1969044 internally. For the sake of triaging the PR backlog, I'm gonna move this to a draft (since we can't merge till the compiler bug is fixed)

[DHowett]

we can't merge till the compiler bug is fixed

The compiler bug reproduces in complete isolation, without TAEF. I don't think this PR caused it, it only found it.

[DHowett]

If this arm64 build passes, I will reupdate and ingest taef 10.92

[DHowett]

The compiler bug may only be fixed by VS 17.11 (!)

[DHowett]

Banished back to draft status