Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: fix class type #6183

Merged
merged 7 commits into from May 15, 2024
Merged

Python: fix class type #6183

merged 7 commits into from May 15, 2024

Conversation

yanzhang100
Copy link
Contributor

Motivation and Context

It should be "ChatMessageContent" type instead of "FunctionCallContent" type.

Description

Contribution Checklist

@yanzhang100 yanzhang100 requested a review from a team as a code owner May 10, 2024 15:11
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label May 10, 2024
@github-actions github-actions bot changed the title fix class type Python: fix class type May 10, 2024
@yanzhang100
Copy link
Contributor Author

@microsoft-github-policy-service agree [company="{your company}"]

@microsoft-github-policy-service agree company="Microsoft"

moonbox3
moonbox3 approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@moonbox3 moonbox3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes.

@moonbox3 moonbox3 enabled auto-merge May 14, 2024 14:15
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented May 14, 2024 •
edited

Py3.10 Test Coverage

Python 3.10 Test Coverage Report •
FileStmtsMissCoverMissing
TOTAL569290484% 
report-only-changed-files is enabled. No files were changed during this commit :)

Python 3.10 Unit Test Overview

Tests Skipped Failures Errors Time
1288 1 💤 0 ❌ 0 🔥 13.916s ⏱️

@moonbox3
Copy link
Contributor

@yanzhang100 can you please fix the formatting (Ruff) error and push the code upstream? Thanks.

auto-merge was automatically disabled May 15, 2024 18:35

Head branch was pushed to by a user without write access

@yanzhang100
Copy link
Contributor Author

@yanzhang100 can you please fix the formatting (Ruff) error and push the code upstream? Thanks.
Fixed the formatting issue. But it shows another issue - Failed Python Test Coverage. Would you please suggest how to fix this? @moonbox3

@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue May 15, 2024
Merged via the queue into microsoft:main with commit ecbc15b May 15, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eavanvalkenburg eavanvalkenburg eavanvalkenburg approved these changes

@moonbox3 moonbox3 moonbox3 approved these changes

Assignees
No one assigned
Labels
python Pull requests for the Python Semantic Kernel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yanzhang100 @markwallace-microsoft @moonbox3 @eavanvalkenburg @YanZhangADS