Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Fix OpenAI/API plugins based on samples path changes. Black formatting for notebooks. #6167

Closed
wants to merge 3 commits into from

Conversation

moonbox3
Copy link
Contributor

@moonbox3 moonbox3 commented May 8, 2024

Motivation and Context

After kernel plugin revamp and restructing samples, the OpenAI/API plugin samples were not working.

Description

This PR fixes:

  • The OpenAI/API plugin concept examples.
  • Updates the 3rd getting_started notebook to match the behavior of dotnet where only chat completion is used, instead of text completion.
  • Reformats via Black 2 getting_started notebooks.

Contribution Checklist

@moonbox3 moonbox3 requested a review from a team as a code owner May 8, 2024 19:12
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label May 8, 2024
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented May 8, 2024

Py3.10 Test Coverage

Python 3.10 Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel/connectors/openapi_plugin
   openapi_manager.py1411589%15, 61–74, 104, 145, 150, 280, 350–363
TOTAL565288784% 

Python 3.10 Unit Test Overview

Tests Skipped Failures Errors Time
1280 1 💤 0 ❌ 0 🔥 16.169s ⏱️

@moonbox3
Copy link
Contributor Author

Was fixed in a subsequent PR. Closing.

@moonbox3 moonbox3 closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants