[node-core-library] [api-extractor] Include typings for the package.json 'exports' and 'typesVersions' fields support for resolving the tsdoc-metadata.json field referenced by 'exports' and 'typesVersions'. #4730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
requested review from
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
As far as I can tell, the 4 (now 5) lookup rules for (The API Extractor docs do specify how to configure where @iclanton if you remind me, I can do that after your PR is merged. |
…lving the tsdoc-metadata.json field referenced by 'exports'.
…rectly reflect the NodeJS resolution algorithm.
iclanton
force-pushed
the
add-support-for-exports-types
branch
from
1b70b97
to
d3a4a75
Compare
iclanton
changed the title
octogonz
approved these changes
May 26, 2024
octogonz
reviewed
May 27, 2024
common/changes/@microsoft/api-extractor/add-support-for-exports-types_2024-05-26-00-41.json
Show resolved
Hide resolved
octogonz
reviewed
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is necessary for allowing the
exportsfield inpackage.jsons to define the default typings location.How it was tested
Tested in a branch that moves
node-core-libraryto useexportsand added unit tests.Impacted documentation
This will probably require updates to the API Extractor and/or tsdoc docs.