Fix an issue with StringBufferTerminalProvider's 'normalizeSpecialCha…

…racters' option.
microsoft · May 25, 2024 · ffb6427 · ffb6427
1 parent fd1e8f5
commit ffb6427
Show file tree

Hide file tree

Showing 4 changed files with 288 additions and 14 deletions.
diff --git a/common/changes/@rushstack/terminal/fix-caching-behavior-undefined_2024-05-25-02-07.json b/common/changes/@rushstack/terminal/fix-caching-behavior-undefined_2024-05-25-02-07.json
@@ -0,0 +1,10 @@
+{
+ "changes": [
+ {
+ "packageName": "@rushstack/terminal",
+ "comment": "Change the `eolCharacter` property value of `StringBufferTerminalProvider` to `\\n` from `[n]`. This does not change the default `getOutput()` result, but removes the `[n]` characters from the `getOutput({ normalizeSpecialCharacters: false })` result.",
+ "type": "minor"
+ }
+ ],
+ "packageName": "@rushstack/terminal"
+}
diff --git a/libraries/rush-lib/src/logic/operations/test/BuildPlanPlugin.test.ts b/libraries/rush-lib/src/logic/operations/test/BuildPlanPlugin.test.ts
@@ -2,13 +2,14 @@
 // See LICENSE in the project root for license information.
 
 import { MockWritable, StringBufferTerminalProvider, Terminal } from '@rushstack/terminal';
+import { JsonFile } from '@rushstack/node-core-library';
+import { StreamCollator } from '@rushstack/stream-collator';
 import { BuildPlanPlugin } from '../BuildPlanPlugin';
 import {
  type ICreateOperationsContext,
  type IExecuteOperationsContext,
  PhasedCommandHooks
 } from '../../../pluginFramework/PhasedCommandHooks';
-import { StreamCollator } from '@rushstack/stream-collator';
 import type { Operation } from '../Operation';
 import { RushConfiguration } from '../../../api/RushConfiguration';
 import {
@@ -24,7 +25,6 @@ import { MockOperationRunner } from './MockOperationRunner';
 import { ProjectChangeAnalyzer } from '../../ProjectChangeAnalyzer';
 import path from 'path';
 import type { ICommandLineJson } from '../../../api/CommandLineJson';
-import { JsonFile } from '@rushstack/node-core-library';
 
 describe(BuildPlanPlugin.name, () => {
  const rushJsonFile: string = path.resolve(__dirname, `../../test/workspaceRepo/rush.json`);