fix: enricher.Instance() returns nil instead of e if e is not initialized

[nddq]

Even if the enricher is not intialized, assigning enricher.Instance() = nil to the plugin's enricher interface will not result in p.enricher == nil equals to true. This is because in Go, an interface holding a nil value is not nil ref . We should not be checking for nil interface with this method.

[timraymond]

There's something that makes me uncomfortable about how this is being used as a singleton, yet we are passing contexts that get discarded into New. I feel like that has a potential to leak goroutines if the first caller's context is disposed of.

Out of curiosity, why does the Enricher need to be a singleton?

[nddq]

There's something that makes me uncomfortable about how this is being used as a singleton, yet we are passing contexts that get discarded into New. I feel like that has a potential to leak goroutines if the first caller's context is disposed of.

Out of curiosity, why does the Enricher need to be a singleton?

this predates my time at this team 🙂 this is just a band aid solution, maybe @anubhabMajumdar can chime in