Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Makefile): Fix the IMAGE_NAMESPACE bash command #47

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

anubhabMajumdar
Copy link
Contributor

No description provided.

Signed-off-by: Anubhab Majumdar <[email protected]>
@anubhabMajumdar anubhabMajumdar requested a review from a team as a code owner March 15, 2024 01:55
@anubhabMajumdar anubhabMajumdar changed the title Topic/anmajumdar/namespace fix gix(Makefile): Fix the IMAGE_NAMESPACE bash command Mar 15, 2024
@anubhabMajumdar anubhabMajumdar changed the title gix(Makefile): Fix the IMAGE_NAMESPACE bash command fix(Makefile): Fix the IMAGE_NAMESPACE bash command Mar 15, 2024
Copy link
Member

@timraymond timraymond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the regexp with SSH and HTTPS flavors, both work. LGTM.

@rbtr rbtr merged commit 3d538e6 into main Mar 15, 2024
18 of 21 checks passed
@rbtr rbtr deleted the topic/anmajumdar/namespace-fix branch March 15, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants