Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Windows drop reasons #406

Merged
merged 4 commits into from
Jun 17, 2024
Merged

feat: add Windows drop reasons #406

merged 4 commits into from
Jun 17, 2024

Conversation

matmerr
Copy link
Member

@matmerr matmerr commented May 24, 2024

Description

Please provide a brief description of the changes made in this pull request.

Add drop reasons specifically to windows builds.

Related Issue

If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@matmerr matmerr requested a review from a team as a code owner May 24, 2024 20:41
@matmerr matmerr requested review from alam-tahmid and nddq May 24, 2024 20:41
@matmerr matmerr force-pushed the matmerr/windowsdropreason branch 2 times, most recently from c77f6a0 to 4905b4e Compare May 28, 2024 19:59
@matmerr matmerr force-pushed the matmerr/windowsdropreason branch from 4905b4e to 975e051 Compare May 28, 2024 20:06
nddq
nddq previously approved these changes May 28, 2024
@nddq nddq added this pull request to the merge queue May 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 31, 2024
@nddq nddq added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit da27278 Jun 17, 2024
22 checks passed
@nddq nddq deleted the matmerr/windowsdropreason branch June 17, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants